Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REC TC decision 1/11/24 - resolution to issue #252 and #244 #254

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

cbupp
Copy link
Collaborator

@cbupp cbupp commented Jan 11, 2024

Resolution to #252 - To align to the W3C Organization Ontology, it was determined that memberOf is preferred to isMemberOf. Since simply renaming would be considered a breaking change, we've decided to create a ODR for deprecating model content (properties and relationships) and implement those decisions on the isMemberOf relationship and create the new memberOf relationship.

Resolution to #244 - System.includes removes the target restriction so that Loops, points, and equipment can be included. This aligns to Brick's usage of System.hasPart. (Though, REC uses includes instead of hasPart for collections, because hasPart is overloaded in it's usage for both inclusion and part-hood.)

@cbupp cbupp requested a review from PeteHart January 11, 2024 18:47
@cbupp cbupp changed the title REC TC decision 1/11/24 - resolution to issue #252 REC TC decision 1/11/24 - resolution to issue #252 and #244 Jan 12, 2024
Copy link
Contributor

@PeteHart PeteHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @cbupp

@PeteHart PeteHart merged commit eb31c75 into main Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants